New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignedJWT support and Reseller API sample to Perl Client Library. #15

Merged
merged 2 commits into from Oct 18, 2014

Conversation

Projects
None yet
3 participants
@richieforeman
Contributor

richieforeman commented Aug 24, 2014

This PR adds OAuth2 Signed JWT (Service Accounts) support to the library.

Summary:

  • Add JSON::WebToken as a dependency.
  • Add Reseller API sample to '/eg/service_accounts/reseller.pl'
  • Add 'Google::API::OAuth2::SignedJWT' class.
  • Shamelessly add myself (and email address) to Authors file.
@captin411

This comment has been minimized.

Show comment
Hide comment
@captin411

captin411 Sep 2, 2014

Does the META.json also need reference to JSON::WebToken as a requirement or does the build process figure it out from cpanfile?

captin411 commented Sep 2, 2014

Does the META.json also need reference to JSON::WebToken as a requirement or does the build process figure it out from cpanfile?

@richieforeman

This comment has been minimized.

Show comment
Hide comment
@richieforeman

richieforeman Sep 2, 2014

Contributor

I must be transparent and admit that my Perl skills are a bit weak. I manually added the requirement to the cpanfile. I would imagine that 'META.json' would also need it -- I can get this PR patched up.

Contributor

richieforeman commented Sep 2, 2014

I must be transparent and admit that my Perl skills are a bit weak. I manually added the requirement to the cpanfile. I would imagine that 'META.json' would also need it -- I can get this PR patched up.

@comewalk

This comment has been minimized.

Show comment
Hide comment
@comewalk

comewalk Oct 9, 2014

Owner

@richieforeman Thank you for your contribution! It looks good to me. I'm ready for merging your PR and pushing to CPAN. Please wait for a while.

@captin411 Thank you for your comment. As a mention for #15 (comment), I use Dist::Milla for building this CPAN module. META.json will be updated through build process, I think. I'll update related files after merging this PR.

Thanks!

Owner

comewalk commented Oct 9, 2014

@richieforeman Thank you for your contribution! It looks good to me. I'm ready for merging your PR and pushing to CPAN. Please wait for a while.

@captin411 Thank you for your comment. As a mention for #15 (comment), I use Dist::Milla for building this CPAN module. META.json will be updated through build process, I think. I'll update related files after merging this PR.

Thanks!

@captin411

This comment has been minimized.

Show comment
Hide comment
@captin411

captin411 Oct 9, 2014

During testing, we did find a separate bug. I will create a separate branch with test cases and patch

captin411 commented Oct 9, 2014

During testing, we did find a separate bug. I will create a separate branch with test cases and patch

comewalk added a commit that referenced this pull request Oct 18, 2014

Merge pull request #15 from richieforeman/signed-jwt
Add SignedJWT support and Reseller API sample to Perl Client Library.

@comewalk comewalk merged commit 553ebb4 into comewalk:master Oct 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@comewalk

This comment has been minimized.

Show comment
Hide comment
@comewalk

comewalk Oct 18, 2014

Owner

@richieforeman just merged! thanks!

Owner

comewalk commented Oct 18, 2014

@richieforeman just merged! thanks!

@comewalk

This comment has been minimized.

Show comment
Hide comment
@comewalk

comewalk Oct 18, 2014

Owner

@captin411 Thank you! Please feel free send a PR 😄

Owner

comewalk commented Oct 18, 2014

@captin411 Thank you! Please feel free send a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment