-
Notifications
You must be signed in to change notification settings - Fork 10
PLAT-142 'Metatags' module global configurations for SEO and social media #147
Conversation
Global settings looks at the meta information for the current page being looked at regardless of what type it is.
og:title added to suppress php error being thrown
@pvhee looks good to me, thoughts? |
label: User | ||
tags: | ||
title: '[user:name] | [site:name]' | ||
og_title: '[user:name] | [site:name]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vireshpatel don't think we need metatags for users since we don't have users on the site? should we remove this snippet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvhee by default there are metatag settings for users and taxonomy.
I had to add the yaml config in as a work around to stop both entity types from throwing errors (and logging them into the watchdog) and until a solution has been found - this is a reported issue: https://www.drupal.org/node/2699487
Cavet for removing config will log errors when people sign into the CMS or are already signed and visit the homepage.
Only other alternative is to swtich metatag
off until and revisit at a later date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vireshpatel ok makes sense! let's leave this in for now then and keep metatag turned on
@pvhee Behat feature tests and feature context removed - to be reintroduced and refined in new ticket and pr. Ready to merge in. |
@vireshpatel cool, merging in |
Ticket
https://jira.comicrelief.com/browse/PLAT-142
Changes proposed in this pull request
Notes:
https://docs.google.com/document/d/1pl30E0ZlLzPs_O-qM5e3admY-SZOzLeMC5x-eu_LbEE/edit
-Behat full tests to be implemented in different ticket and PR (ones originally implemented in PR where partial so removed accordingly)