Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-142 'Metatags' module global configurations for SEO and social media #147

Merged
merged 9 commits into from
Apr 12, 2016

Conversation

vireshpatel
Copy link
Contributor

Ticket

https://jira.comicrelief.com/browse/PLAT-142

Changes proposed in this pull request

  • Set Metatags global configurations (site-wide)
  • Set content types to use global configurations
  • Set Metatags module taxonomy configurations (og:title added to suppress php error being thrown)
  • Set Metatags module user configurations (og:title added to suppress php error being thrown)
  • Metatags module user configurations added to CR config profile

Notes:

  • Image fields for og:image not included as feature isnt working - bug in module - raising separate ticket and action
  • Meta description tag not included - to determine best of course of action later (discussed in SEO doc), summary field pulls in html markup (not best practice) - raising separate ticket and action
  • CR SEO doc with links to resources and tools:
    https://docs.google.com/document/d/1pl30E0ZlLzPs_O-qM5e3admY-SZOzLeMC5x-eu_LbEE/edit
  • Drupal core also outputs its own metatags - separate ticket being raised to suppress them
    -Behat full tests to be implemented in different ticket and PR (ones originally implemented in PR where partial so removed accordingly)

Viresh Patel added 2 commits April 7, 2016 15:10
Global settings looks at the meta information for the current page being looked at regardless of what type it is.
@vireshpatel vireshpatel changed the title PLAT-142 SEO Metatags module configurations PLAT-142 'Metatags' module global configurations for SEO and social media Apr 11, 2016
@bimsonz
Copy link
Contributor

bimsonz commented Apr 12, 2016

@pvhee looks good to me, thoughts?

label: User
tags:
title: '[user:name] | [site:name]'
og_title: '[user:name] | [site:name]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vireshpatel don't think we need metatags for users since we don't have users on the site? should we remove this snippet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvhee by default there are metatag settings for users and taxonomy.

I had to add the yaml config in as a work around to stop both entity types from throwing errors (and logging them into the watchdog) and until a solution has been found - this is a reported issue: https://www.drupal.org/node/2699487

Cavet for removing config will log errors when people sign into the CMS or are already signed and visit the homepage.

Only other alternative is to swtich metatag off until and revisit at a later date.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vireshpatel ok makes sense! let's leave this in for now then and keep metatag turned on

@vireshpatel
Copy link
Contributor Author

@pvhee Behat feature tests and feature context removed - to be reintroduced and refined in new ticket and pr.

Ready to merge in.

@pvhee
Copy link
Contributor

pvhee commented Apr 12, 2016

@vireshpatel cool, merging in

@pvhee pvhee merged commit 2ced01c into develop Apr 12, 2016
@pvhee pvhee deleted the feature/PLAT-142_seo_metatag_configurations branch April 12, 2016 15:47
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants