-
Notifications
You must be signed in to change notification settings - Fork 10
PLAT-24 Add metatags fieldset to News article content type #153
PLAT-24 Add metatags fieldset to News article content type #153
Conversation
…'article' content type Pathauto dependency added to auto-generate friendly urls
@pvhee Again, looks alright to me, any thoughts? |
- metatag | ||
- node | ||
id: node.field_meta_tags | ||
field_name: field_meta_tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vireshpatel if this is an article specific field, it should be prepended with article
, like field_article_meta_tags
. If we're gonna reuse this field it can be named like it is now but then it should be part of the CR profile and not the cr_article module I believe. \cc @bimsonz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvhee @bimsonz:
field_meta_tags
is intended to be reused for other types and just article
- I'll move this to the CR profile.
I followed the implementation and naming convention currently in place for cr_article
and also hence why I updated the architecture documentation. If the naming convention should be as you say @pvhee, then do we need to look at revising cr_article
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vireshpatel yes, could you put in a ticket pls? I think it's important we get this straight from the start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvhee no problem - ticket PLAT-152 created.
Cool, will merge this one though, since names can be refactored as part of PLAT-152 then |
Ticket
https://jira.comicrelief.com/browse/PLAT-24
Overview
Changes proposed in this pull request