Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-591 URL change news landing page #625

Merged
merged 12 commits into from
Nov 21, 2016

Conversation

Heleen-cr
Copy link
Contributor

@Heleen-cr Heleen-cr commented Nov 10, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-591

Changes proposed in this pull request

  • change the URL pattern of articles to be /news-tv-and-events/news/[node:title]
  • add /news-tv-and-events/news to the page restriction of what's going on list view block.

Manual steps

  • path alias of news landing page needs to be changed from "whats-going-on" to /news-tv-and-events/news
  • what's going on menu link needs to be updated
    Probably steps to be done by the content managers?

… page and added this URL to the page restrictions of the whats going on list view block
@Heleen-cr Heleen-cr added this to the 1.18.0 milestone Nov 10, 2016
@bimsonz bimsonz modified the milestones: 1.19.0, 1.18.0 Nov 16, 2016
Copy link
Contributor

@pvhee pvhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looking good for me @Heleen-cr !

One thing is that I'd like to have @CarolineRennie feed back on the URL change before merging this in. If she's OK we can go ahead. See https://jira.comicrelief.com/browse/PLAT-591#comment-74630

Given I am on "whats-going-on"
And I should see the link "Four down – one to go!"
Then I follow "Four down – one to go!"
And I should see the text "Greg James struggled on the penultimate day of Gregathlon"

@api @default-content
Scenario: Article pagination on /whats-going
Scenario: Article pagination on /whats-going-on
Given I am on "whats-going-on"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not suppose to be a URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel not sure what you mean

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that part of the test is going to whats-going-on, so you are not going to change that URL, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the default content will be whats-going-on and the path of the news landing page will be manually changed. So in order to pass the test it needs to point to whats-going-on.

Copy link
Contributor

@pvhee pvhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Caroline and we're OK to go with the new URL structure. It should fit all campaigns and not just RND

@AndyEPhipps AndyEPhipps merged commit 79033d9 into develop Nov 21, 2016
@AndyEPhipps AndyEPhipps deleted the plat-591-url-change-news-landing-page branch November 21, 2016 10:27
@Saphyel Saphyel changed the title plat-591 URL change news landing page PLAT-591 URL change news landing page Nov 22, 2016
@Saphyel Saphyel mentioned this pull request Nov 22, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants