-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
… page and added this URL to the page restrictions of the whats going on list view block
…o plat-591-url-change-news-landing-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looking good for me @Heleen-cr !
One thing is that I'd like to have @CarolineRennie feed back on the URL change before merging this in. If she's OK we can go ahead. See https://jira.comicrelief.com/browse/PLAT-591#comment-74630
Given I am on "whats-going-on" | ||
And I should see the link "Four down – one to go!" | ||
Then I follow "Four down – one to go!" | ||
And I should see the text "Greg James struggled on the penultimate day of Gregathlon" | ||
|
||
@api @default-content | ||
Scenario: Article pagination on /whats-going | ||
Scenario: Article pagination on /whats-going-on | ||
Given I am on "whats-going-on" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not suppose to be a URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saphyel not sure what you mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that part of the test is going to whats-going-on
, so you are not going to change that URL, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the default content will be whats-going-on and the path of the news landing page will be manually changed. So in order to pass the test it needs to point to whats-going-on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to Caroline and we're OK to go with the new URL structure. It should fit all campaigns and not just RND
Fixes https://jira.comicrelief.com/browse/PLAT-591
Changes proposed in this pull request
Manual steps
Probably steps to be done by the content managers?