This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
1.19.0 #650
Merged
1.19.0 #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page and added this URL to the page restrictions of the whats going on list view block
This reverts commit 05a181f.
This reverts commit 600fe23.
…20_update_ESU_icon
…ons provided through the module
…o PLAT-594-padding-options-single-message
…ts instead of having it in the middle
…o plat-591-url-change-news-landing-page
PLAT-520: update esu icon
…o plat-591-url-change-news-landing-page
…o PLAT-594-padding-options-single-message
…o PLAT-594-padding-options-single-message
Feature/plat 608 svg search
…o plat-480-esu-school-phase-dropdown-error-border
Feature/rnd 517 fix header kids
…gle-message Plat 594 padding options single message row
…o feature/PLAT-618_cw_m_image
…o plat-480-esu-school-phase-dropdown-error-border
…crelief/campaign into feature/PLAT-618_cw_m_image
…opdown-error-border plat-480 ESU school phase dropdown error border
PLAT 618 cw universal image
bimsonz
reviewed
Nov 23, 2016
| @@ -123,6 +123,8 @@ | |||
| <target name="install" description="Install CR with standard configuration."> | |||
| <exec dir="${app.dir}" logoutput="true" passthru="true" checkreturn="true" | |||
| command="${drush.bin} si ${app.profile.name} -y --site-name=${app.name} --account-pass='${app.password}' --db-url=${db.querystring} ${app.profile.options}"/> | |||
| <exec dir="${app.dir}" | |||
There was a problem hiding this comment.
@Saphyel how come we are exporting config dir after install ?
There was a problem hiding this comment.
it was discussed in the drupal 8 101 //cc @pvhee
There was a problem hiding this comment.
my understanding was that this was a useful tool for when checking config you've changed during development, not something we need to do on every install, right ?
There was a problem hiding this comment.
@bimsonz if you change something is useful otherwise is not.. but we are dealing mainly with config changes... and we still have a lot of problems with it.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/comicrelief/campaign/milestone/17
https://jira.comicrelief.com/secure/ReleaseNote.jspa?projectId=11402&version=10974
#646 - PLAT-608 svg search
#625 - PLAT-591 URL change news landing page *
#644 - PLAT-491 cards row title spacing
#641 - PLAT-619 Update ESU values *
#648 - RND-517 fix header kids
#636 - PLAT-614 partner row logo updates
#642 - PLAT-620 fixed merge conflict
#643 - RND-519 cards padding perc issue
#630 - RND-476 add ie9 support
#628 - PLAT-520 update esu icon
#635 - PLAT-600 Story row component updates
#629 - PLAT-594 padding options single message row
#647 - PLAT-480 ESU school phase dropdown error border
#640 - PLAT-618 ESU school phase dropdown error border
#645 - update readme IE9 support info