RND-476 add ie9 support #630
Conversation
|
@pvhee @bimsonz @Saphyel @Heleen-cr @AndyEPhipps .. if you have an idea how to tackle it in drupal 8. |
|
@gusliedke @pvhee I found this... but I didn't test it: |
|
@Saphyel gonna give it a try |
|
Disable css aggregation is good to not include a stylesheet in drupal core aggregation. But it doesn't split the stylesheet in different files to fix IE9 bug. |
|
@pvhee If we don't have other solution I think we should push this code .. it will only affect IE9. And I will create a documentation about it. |
|
@gusliedke can you provide documentation on this and/or discuss with @AndyEPhipps @Heleen-cr so they're able to follow the same splitting? Then it's OK for me to go in without the use of a D8 module The only thing I'd like to see still is some discussion on d.o. talking about this problem and proposing a solution, we can't be the only ones having these issues |
|
Not many big sites in drupal 8 that supports ie9 I guess .. https://www.unicef.es/ has same issue ie9 |
|
ie9 and ie8 are both < 1% traffic .. we don't need to maintain this fix for much time .. people will not invest time to sort this out. |
There was a problem hiding this comment.
@gusliedke cool, let's get this merged then if QA approved.
|
MS does no longer support 10 or older version since a year... why do we have to provide support to a insecure and legacy browser when even the owner give up at them? |
|
@Saphyel because of our users, innit |
https://jira.comicrelief.com/browse/RND-476
IE 9 CSS limitation by preventing more than 4095 selectors in a CSS file.
I'm surprised drupal 8 doesn't deal with it by default .. haven't found much documentation about it.
There is this module https://www.drupal.org/project/advagg but it's quite big with too many settings. It works but when you split the stylesheet it should add those files in a condition to only load on IE9 not in all browsers.
I've added the condition in the html template manually, used http://blesscss.com/ to split the stylesheet and committed the CSS files. This is only used by IE9 .. so we don't need to worry too much about it. This is a temp solution to test the issue.
Please let me know if you have other solutions!