This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-614: partner row logo updates #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 17, 2016 14:26
…e/PLAT-614_Partner_row_logo_updates
Saphyel
reviewed
Nov 18, 2016
| effects: | ||
| e6b123ff-fc13-4987-a8dd-7e6b54d11ab2: | ||
| uuid: e6b123ff-fc13-4987-a8dd-7e6b54d11ab2 | ||
| id: focal_point_crop |
There was a problem hiding this comment.
This is just a question... is necessary that be a focal point thing?
There was a problem hiding this comment.
Yep, why?
edit: could just make it standard crop; but what's the issue with FP?
There was a problem hiding this comment.
I'd like to avoid to use it more than need (if we finally are going to update that module some day... the less dependencies the better)
There was a problem hiding this comment.
Okeydokey, will try to swap em out for the standard crop
added 5 commits
November 18, 2016 12:06
…e/PLAT-614_Partner_row_logo_updates
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.comicrelief.com/browse/PLAT-614