Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Ensure seeds cannot be printed #722

Closed
D4nte opened this issue Jan 25, 2019 · 1 comment · Fixed by #1027
Closed

Ensure seeds cannot be printed #722

D4nte opened this issue Jan 25, 2019 · 1 comment · Fixed by #1027
Assignees
@tcharding
Labels
added-mid-sprint good first issue Good for newcomers
Milestone
Sprint 15 🥾⌨️

Comments

@D4nte
Copy link
Contributor

D4nte commented Jan 25, 2019 •
edited

Change the Display/Debug impl for the seed type to ensure it does not get printed ever.
@D4nte D4nte mentioned this issue Jan 25, 2019
Closed
@D4nte D4nte changed the title Be considerate when printing settings in logs as it contains seed Ensure seeds cannot be printed May 6, 2019
@D4nte D4nte added the good first issue Good for newcomers label May 6, 2019
tcharding added a commit that referenced this issue Jun 7, 2019
@tcharding
Ensure seeds cannot be printed
0490a74 
We don't want to display (or debug out) seeds.   Implement dummy methods for
Display trait and Debug.  Add test to ensure the dummy implementations don't get
changed.

Fixes: #722

Signed-off-by: tcharding <me@tobin.cc>
@tcharding tcharding mentioned this issue Jun 7, 2019
Merged
@D4nte D4nte added this to the Sprint 15 🥾⌨️ milestone Jun 7, 2019
D4nte pushed a commit that referenced this issue Jun 8, 2019
@tcharding
Ensure seeds cannot be printed
2e9c039 
We don't want to display (or debug out) seeds.   Implement dummy methods for
Display trait and Debug.  Add test to ensure the dummy implementations don't get
changed.

Fixes: #722

Signed-off-by: tcharding <me@tobin.cc>
D4nte pushed a commit that referenced this issue Jun 8, 2019
@tcharding
Ensure seeds cannot be printed
416f5c6 
We don't want to display (or debug out) seeds.   Implement dummy methods for
Display trait and Debug.  Add test to ensure the dummy implementations don't get
changed.

Fixes: #722

Signed-off-by: tcharding <me@tobin.cc>
@tcharding
Copy link
Collaborator

closed in #1027

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tcharding tcharding

Labels
added-mid-sprint good first issue Good for newcomers
Projects
None yet
Milestone
Sprint 15 🥾⌨️
Development

Successfully merging a pull request may close this issue.

Ensure seeds cannot be printed comit-network/comit-rs
2 participants
@D4nte @tcharding