[Issue #168] Close open resources.

comixed · Mar 4, 2020 · d3e89d6 · d3e89d6
1 parent 1b62d7d
commit d3e89d6
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/comixed-library/src/main/java/org/comixed/adaptors/archive/ZipArchiveAdaptor.java b/comixed-library/src/main/java/org/comixed/adaptors/archive/ZipArchiveAdaptor.java
@@ -135,7 +135,7 @@ protected ZipFile openArchive(File comicFile) throws ArchiveAdaptorException {
 
   @Override
   void saveComicInternal(Comic source, String filename, boolean renamePages)
-      throws ArchiveAdaptorException {
+      throws ArchiveAdaptorException, IOException {
     logger.debug("Creating temporary file: " + filename);
 
     ZipArchiveOutputStream zoutput = null;
@@ -171,11 +171,13 @@ void saveComicInternal(Comic source, String filename, boolean renamePages)
         zoutput.write(page.getContent());
         zoutput.closeArchiveEntry();
       }
-
-      zoutput.finish();
-      zoutput.close();
     } catch (IOException | ArchiveException error) {
       throw new ArchiveAdaptorException("error creating comic archive", error);
+    } finally {
+      if (zoutput != null) {
+        zoutput.finish();
+        zoutput.close();
+      }
     }
   }