New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comics can be converted to another format #137
Comments
Couple of thoughts on this one - should blocked or deleted images be included in the new file? What happens if the new format = old format? |
@bareheiny This is a good topic for discussion in the user mailing list. That way we can get a consensus from other users. |
…ew archive type.
Just read the steps you’ve detailed properly - for step 3, delete old archive, should the user be asked first? I’d imagine some users may want to keep the original archive as well. |
@bareheiny Right now, I've got things to the point of doing all but the delete. I suppose I could leave it at that. Then the user can decide later to delete the old comic if they so choose. I was thinking of how CR does things now with exporting comics replacing the source with the newly created comic. |
I’m likely mistaken, but I thought CR gave you the option to replace? For sure there are advanced options for conversion if you bypass the basic zip/rar options - these include conversion to webp and excluding images marked for deletion. |
It was as configurable option with the default being "Export to: Same Folder and replace in Library". And then there were a lot of extended options to control that process, far beyond the scope of what is being added with this feature. We can add those additional behaviors and options later, but I'm can't boil the ocean today. ;) |
Fair call! I only recently looked past the default export options - usually I would just conver to cbz, delete and replace. But it's nice to know one has the option to not delete the comics - some people would likely get tetchy about that sort of thing. |
@bareheiny No doubt. 😄 So as it stands, I'm going to put up a PR for this and let it add the new comic to the library without deleting the source comic. I've created #184 to let the admin choose explicitly to delete the source comics on conversion, as well as #185 to opt-in to delete blocked pages as well. |
…ew archive type.
…ew archive type.
…ew archive type.
* [Issue #137] Add the ConvertComicWorkerTask class and tests. * [Issue #137] Add the ConvertComicTaskEncoder class and tests. * [Issue #137] Add the ConvertComicsWorkerTask class and tests. * [Issue #137] Add a service method for converting comics to a new archive type. * [Issue #137] Add REST API for converting comics. * [Issue #137] Add library actions to convert comics. * [Issue #137] Add the ConvertComisSettings component and tests. * [Issue #137] Don't allow imports while comics are processing.
* [Issue #137] Add the ConvertComicWorkerTask class and tests. * [Issue #137] Add the ConvertComicTaskEncoder class and tests. * [Issue #137] Add the ConvertComicsWorkerTask class and tests. * [Issue #137] Add a service method for converting comics to a new archive type. * [Issue #137] Add REST API for converting comics. * [Issue #137] Add library actions to convert comics. * [Issue #137] Add the ConvertComisSettings component and tests. * [Issue #137] Don't allow imports while comics are processing.
As a library owner, I would like to be able to convert comics in my library to other archive formats.
Preconditions
User Story:
Postconditions:
The text was updated successfully, but these errors were encountered: