Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When converting comics, the admin can choose to delete the original comic #184

Closed
mcpierce opened this issue Mar 17, 2020 · 3 comments
Closed

When converting comics, the admin can choose to delete the original comic #184

mcpierce opened this issue Mar 17, 2020 · 3 comments
Assignees
@BRUCELLA2
Labels
feature A new feature or enhancement to an exisiting feature library Issues related to loading, display or working with the library of comics
Milestone
0.7

Comments

@mcpierce
Copy link
Contributor

mcpierce commented Mar 17, 2020 •
edited

When converting comics, the admin can check a box to tell the backend to delete the original comic once the conversion completes successfully.

Acceptance Criteria

  1. Any reading list in which the original comic was a member will have the new comic as well.
@mcpierce mcpierce added the library Issues related to loading, display or working with the library of comics label Mar 17, 2020
@mcpierce mcpierce added this to the No Milestone milestone Mar 17, 2020
@mcpierce mcpierce mentioned this issue Mar 17, 2020
Closed
@mcpierce mcpierce modified the milestones: No Milestone, 0.7 Jun 2, 2020
@mcpierce mcpierce assigned mcpierce and unassigned mcpierce Jul 1, 2020
@mcpierce mcpierce added enhancement A pull request containing a a new feature, refactoring, or security improvement.. feature A new feature or enhancement to an exisiting feature and removed enhancement A pull request containing a a new feature, refactoring, or security improvement.. labels Jul 5, 2020
@BRUCELLA2 BRUCELLA2 self-assigned this Jul 22, 2020
@BRUCELLA2
Copy link
Contributor

When we delete the original comic, if the original comic was in reading lists, the new comic converted must also be in reading lists ?

@mcpierce
Copy link
Contributor Author

@BRUCELLA2 Good point. And if the original isn't deleted then both comics should be put into the reading list, yeah?

@BRUCELLA2
Copy link
Contributor

@BRUCELLA2 Good point. And if the original isn't deleted then both comics should be put into the reading list, yeah?

Yes we can do that.

BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue Aug 2, 2020
@BRUCELLA2
Added option to delete original comic when converting comics [comixed…
9b1284f 
…#184]

- When converting comics, the admin can choose to delete the original comic

various fix on added option to delete original comic
mcpierce pushed a commit that referenced this issue Aug 3, 2020
@BRUCELLA2 @mcpierce
Added option to delete original comic when converting comics [#184]
92ec52f 
- When converting comics, the admin can choose to delete the original comic

various fix on added option to delete original comic
@mcpierce mcpierce closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BRUCELLA2 BRUCELLA2

Labels
feature A new feature or enhancement to an exisiting feature library Issues related to loading, display or working with the library of comics
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@mcpierce @BRUCELLA2