Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a proper field to the comic state to identify when the comic is not found #188

Closed
mcpierce opened this issue Mar 18, 2020 · 0 comments
Closed

Add a proper field to the comic state to identify when the comic is not found #188

mcpierce opened this issue Mar 18, 2020 · 0 comments
Assignees
@mcpierce
Labels
library Issues related to loading, display or working with the library of comics
Milestone
0.6

Comments

@mcpierce
Copy link
Contributor

Currently, when opening the comic details page, an alert is always showing saying no comic was found. This is due to the comic being initially void and the page component thinking that means the comic wasn't found.

Instead, when the ComicGet action results in ComicGetIssueFailed, a new field (noSuchComic) should be set to true to make it clear that no such comic exists. This way it's a straight forward indicator of that scenario.
@mcpierce mcpierce added the library Issues related to loading, display or working with the library of comics label Mar 18, 2020
@mcpierce mcpierce added this to the 0.6 milestone Mar 18, 2020
@mcpierce mcpierce self-assigned this Mar 18, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Mar 18, 2020
@mcpierce
[Issue comixed#188] Add a noComic field to the comics state wiring.
d00f190
mcpierce added a commit to mcpierce/comixed that referenced this issue Mar 18, 2020
@mcpierce
[Issue comixed#188] Integrate the new state field into the comic page.
9b3c5e3
mcpierce added a commit that referenced this issue Mar 18, 2020
@mcpierce
[Issue #188] Add explicit missing comic field to comic state. (#190)
1feeca6 
* [Issue #188] Add a noComic field to the comics state wiring.

* [Issue #188] Integrate the new state field into the comic page.
mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
[Issue #188] Add explicit missing comic field to comic state. (#190)
8ed9698 
* [Issue #188] Add a noComic field to the comics state wiring.

* [Issue #188] Integrate the new state field into the comic page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
library Issues related to loading, display or working with the library of comics
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@mcpierce