Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #188] Add explicit missing comic field to comic state. #190

Merged
merged 2 commits into from Mar 18, 2020

Conversation

mcpierce
Copy link
Contributor

Status

READY

Migrations

NO

Description

Add a new field to the comics state to track when a comic is actually not found. Only show toaster in that case.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Mar 18, 2020
@mcpierce mcpierce added this to the 0.6 milestone Mar 18, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit 1feeca6 into comixed:develop Mar 18, 2020
@mcpierce mcpierce deleted the feature/issue-188 branch March 18, 2020 21:34
mcpierce added a commit that referenced this pull request Jun 22, 2020
* [Issue #188] Add a noComic field to the comics state wiring.

* [Issue #188] Integrate the new state field into the comic page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant