Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Reading List Details pop up can only be closed via Cancel or Save - not with the X button. #319

Closed
bareheiny opened this issue Jun 7, 2020 · 6 comments
Assignees
Labels
bug Something isn't working user interface Issues related to the frontend
Milestone

Comments

@bareheiny
Copy link

Describe the bug
The Reading List Details pop up can only be closed via Cancel or Save - not with the X button on the top left corner of the pop up.

To Reproduce
Steps to reproduce the behavior:

  1. Create (or edit) a reading list
  2. Press the X in the top left corner of the pop up.
  3. Note that nothing happens
  4. Press the Cancel button
  5. Note that the pop up is closed

Expected behavior
I would expect the X to function the same way as the Cancel button does - it should close the pop up.

Desktop (please complete the following information):

  • ComiXed version 0.6.0-0.rc6
  • OS: Windows 10
  • Browser name Edge (chromium)
  • Browser version 83.0.478.45

** ComiXed Build Detail **

Source Branch 79bca8b
Build Hostname fv-az50
Built On Jun 6, 2020, 5:46:20 PM
Version 0.6.0-0.rc6
Commit Hash 79bca8b
Committer Name Darryl L. Pierce (mcpierce@gmail.com)
Time Of Last Commit Jun 6, 2020, 5:26:52 PM
Commit Message Changed the select reading list dialog to close after adding comics [#315]
Built From Uncommitted Code? true
Remote Origin https://github.com/comixed/comixed
@mcpierce mcpierce added the duplicate issue This issue or pull request already exists label Jun 7, 2020
@mcpierce
Copy link
Contributor

mcpierce commented Jun 7, 2020

@bareheiny Marking this as a duplicate of #315 (the fix in included in rc7). Could you verify that and close this ticket after?

@mcpierce mcpierce added the wontfix This will not be worked on label Jun 7, 2020
@bareheiny
Copy link
Author

The X button isn't closing the dialog box.

Version: 0.6.0-0.rc9

@mcpierce
Copy link
Contributor

@bareheiny Okay. I'll promote it to a bug then.

@mcpierce mcpierce added bug Something isn't working user interface Issues related to the frontend and removed duplicate issue This issue or pull request already exists wontfix This will not be worked on labels Jun 15, 2020
@mcpierce mcpierce added this to the 0.7 milestone Jun 15, 2020
@mcpierce
Copy link
Contributor

mcpierce commented Jul 2, 2020

@bareheiny A fix has been merged into develop. Can you verify it and, if it works, please close this ticket?

@bareheiny
Copy link
Author

This looks good, so closing.

@mcpierce, reading lists in the latest development build may not be working correctly. I likely won't get a chance to create an issue for a few days - but it may be worth just creating a new reading list and trying to add a comic to the list. Checking the pop-out when adding to a comic to a list, and checking the reading list was created successfully via the Library navigation menu.

@mcpierce
Copy link
Contributor

mcpierce commented Jul 8, 2020

@bareheiny I'll look into it. I'd like to avoid opening bugs against development issues, though, since we could end up with tons of development (rather than release) issues which could get overwhelming. Could you instead shoot an email to the dev list about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user interface Issues related to the frontend
Projects
None yet
Development

No branches or pull requests

3 participants