Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SonarCloud-identified issues. #354

Closed
mcpierce opened this issue Jun 15, 2020 · 0 comments
Closed

Fix SonarCloud-identified issues. #354

mcpierce opened this issue Jun 15, 2020 · 0 comments
Assignees
@mcpierce
Labels
feature A new feature or enhancement to an exisiting feature
Milestone
0.7

Comments

@mcpierce
Copy link
Contributor

After #350 a number of new issues have been identified in the codebase.
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Jun 15, 2020
@mcpierce mcpierce added this to the 0.7 milestone Jun 15, 2020
@mcpierce mcpierce self-assigned this Jun 15, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 15, 2020
@mcpierce
Changed the save and encoded methods to use try-with-resources [comix…
32b0f25 
…ed#354]
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 15, 2020
@mcpierce
Added logging whether the temporary file is deleted or not [comixed#354]
b8b3c30
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 15, 2020
@mcpierce
Changed the visibility for the mask and bean fields [comixed#354]
0b2e0a5
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 15, 2020
@mcpierce
Changed the visibility of fields on OPDSEntry [comixed#354]
c3f2db9
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 27, 2020
@mcpierce
Changed the save and encoded methods to use try-with-resources [comix…
d881b5d 
…ed#354]
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 27, 2020
@mcpierce
Added logging whether the temporary file is deleted or not [comixed#354]
5b5336f
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 27, 2020
@mcpierce
Changed the visibility for the mask and bean fields [comixed#354]
6cb46b3
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 27, 2020
@mcpierce
Changed the visibility of fields on OPDSEntry [comixed#354]
1edb3f7
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 27, 2020
@mcpierce
Changed log references to not use "this" qualifier [comixed#354]
d1bdedd
mcpierce added a commit that referenced this issue Jun 27, 2020
@mcpierce
Changed the save and encoded methods to use try-with-resources [#354]
74bdb35
mcpierce added a commit that referenced this issue Jun 27, 2020
@mcpierce
Added logging whether the temporary file is deleted or not [#354]
161db33
mcpierce added a commit that referenced this issue Jun 27, 2020
@mcpierce
Changed the visibility for the mask and bean fields [#354]
65b2177
mcpierce added a commit that referenced this issue Jun 27, 2020
@mcpierce
Changed the visibility of fields on OPDSEntry [#354]
5e862a6
mcpierce added a commit that referenced this issue Jun 27, 2020
@mcpierce
Changed log references to not use "this" qualifier [#354]
69f73b2
@mcpierce mcpierce added feature A new feature or enhancement to an exisiting feature and removed enhancement A pull request containing a a new feature, refactoring, or security improvement.. labels Jul 6, 2020
@mcpierce mcpierce reopened this May 8, 2021
mcpierce added a commit to mcpierce/comixed that referenced this issue May 8, 2021
@mcpierce
Fixed more issues reported by SonarCloud [comixed#354]
05e2edd
mcpierce added a commit that referenced this issue May 9, 2021
@mcpierce
Fixed more issues reported by SonarCloud [#354]
1a54d05
mcpierce added a commit to mcpierce/comixed that referenced this issue May 9, 2021
@mcpierce
Fixed more issues reported by SonarCloud [comixed#354]
654ba58 
 * Changed ComicFileUtils to a component.
mcpierce added a commit that referenced this issue May 9, 2021
@mcpierce
Fixed more issues reported by SonarCloud [#354]
9276e79 
 * Changed ComicFileUtils to a component.
@mcpierce mcpierce mentioned this issue May 10, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
feature A new feature or enhancement to an exisiting feature
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
1 participant
@mcpierce