Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the comixed-messaging module [#725] #732

Merged
merged 1 commit into from May 10, 2021
Merged

Added the comixed-messaging module [#725] #732

merged 1 commit into from May 10, 2021

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented May 8, 2021

  • Added publishing actions to send updates to topics.
  • Removed topics for loading scan types and formats.
  • Added loading scan types and formats via HTTP requests.

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label May 8, 2021
@mcpierce mcpierce added this to the 0.9 milestone May 8, 2021
@mcpierce mcpierce force-pushed the feature/issue-725 branch 2 times, most recently from caefd94 to e986271 Compare May 10, 2021 01:20
@mcpierce
Added the comixed-messaging module [comixed#725]
59446a9 
 * Added publishing actions to send updates to topics.
 * Removed topics for loading scan types and formats.
 * Added loading scan types and formats via HTTP requests.
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

46.3% 46.3% Coverage
0.0% 0.0% Duplication

BRUCELLA2
BRUCELLA2 reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@BRUCELLA2 BRUCELLA2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage code seems to be broken since some PR.
Other than that, it's ok.

@mcpierce
Copy link
Contributor Author

The coverage code seems to be broken since some PR.
Other than that, it's ok.

Yes it's constantly saying things have no or little coverage when everything I push up has 100% coverage. That's partly why I've reopened #354 to start fixing other things so see if I can find the problem.

@mcpierce mcpierce merged commit 7560a89 into comixed:develop May 10, 2021
@mcpierce mcpierce deleted the feature/issue-725 branch May 10, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 BRUCELLA2 left review comments

Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcpierce @BRUCELLA2