Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added adjusting cover dates for timezons [#1110] #1111

Merged
merged 1 commit into from Dec 11, 2021
Merged

Added adjusting cover dates for timezons [#1110] #1111

merged 1 commit into from Dec 11, 2021

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Dec 9, 2021

Also, added the store date to the comic overview display and
improved the unit test coverage for ScrapingService.

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Added adjusting cover dates for timezons [comixed#1110]
641ba33 
Also, added the store date to the comic overview display and
improved the unit test coverage for ScrapingService.
@mcpierce mcpierce added enhancement A pull request containing a a new feature, refactoring, or security improvement.. bugfix A pull request containing a fix for an issue. labels Dec 9, 2021
@mcpierce mcpierce added this to the 0.11 milestone Dec 9, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit 61de998 into comixed:master Dec 11, 2021
@mcpierce mcpierce deleted the feature/issue-1110 branch December 11, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 Awaiting requested review from BRUCELLA2

@jmcrfp jmcrfp Awaiting requested review from jmcrfp

Assignees
No one assigned
Labels
bugfix A pull request containing a fix for an issue. enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcpierce