split pandaState into pandaState and peripheralState #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really sure what you're trying to accomplish by splitting these out like this. Wouldn't it suffice to just do something like this: or even just where the first entry will always be the internal one? |
|
The goal is to split driving related tasks from what we hacked into the panda state to control the device. Think this is a good change regardless of multiple panda support. It also makes the upcoming changes to boardd easier to reason about since you can have two different threads and you can pass the appropriate panda to each one. |
pd0wm
force-pushed
the
peripheral-state
branch
from
ca253b9
to
e4ff64c
Compare
log.capnp
Outdated
| @@ -393,6 +387,12 @@ struct PandaState @0xa7649e2575e4591e { | |||
| harnessStatus @21 :HarnessStatus; | |||
| heartbeatLost @22 :Bool; | |||
|
|
|||
| voltageDEPRECATED @0 :UInt32; | |||
There was a problem hiding this comment.
deprecated fields usually go at the bottom
pd0wm
force-pushed
the
peripheral-state
branch
from
3e834f1
to
e80c48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.