Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

818,820,821,834,835,836,837,838,842 #122

Merged
merged 9 commits into from
Mar 7, 2020
Merged

818,820,821,834,835,836,837,838,842 #122

merged 9 commits into from
Mar 7, 2020

Conversation

uselessinfodude
Copy link

No description provided.

@uselessinfodude uselessinfodude changed the title 818,820,821 818,820,821,834 Mar 6, 2020
@uselessinfodude uselessinfodude changed the title 818,820,821,834 818,820,821,834,835 Mar 6, 2020
@uselessinfodude uselessinfodude changed the title 818,820,821,834,835 818,820,821,834,835,836 Mar 6, 2020
@uselessinfodude uselessinfodude changed the title 818,820,821,834,835,836 818,820,821,834,835,836,837 Mar 6, 2020
Copy link
Collaborator

@pjlao307 pjlao307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

818 - The road on the other side of the railing should be marked. On the right side there looks to be a car on the exit ramp which should also be marked as a road.
image

834 - Some of the lane lines in the distance should also be tagged. Also, that lane line on the far right looks kind of off.
image

835 - Those lane lines in the opposite side of the road should be marked.
image

@uselessinfodude
Copy link
Author

Changes made

@pjlao307
Copy link
Collaborator

pjlao307 commented Mar 6, 2020

834,835 look good. 818 is still missing the road marking on the left side (past the railing).
image

@uselessinfodude
Copy link
Author

Made the change although it looks like a curb or edge of road to me

@uselessinfodude uselessinfodude changed the title 818,820,821,834,835,836,837 818,820,821,834,835,836,837,838 Mar 7, 2020
@uselessinfodude uselessinfodude changed the title 818,820,821,834,835,836,837,838 818,820,821,834,835,836,837,838,842 Mar 7, 2020
@pjlao307 pjlao307 merged commit 895d4a1 into commaai:master Mar 7, 2020
@pjlao307 pjlao307 mentioned this pull request Mar 7, 2020
mutusmurum added a commit to mutusmurum/comma10k that referenced this pull request May 16, 2020
mutusmurum added a commit that referenced this pull request May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants