add info tooltips #269
Merged
add info tooltips #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've deployed this to staging so that you can preview it |
|
Looks great on PC, but very hard to hit on mobile. Perhaps we can make clicking on the text also trigger this instead of the toggle? I think that makes sense anyway. |
|
The switch and label are a single combined component from material ui so I can't easily remove the click listener from the label |
|
I've at least made it so that when you tap the info icon on mobile the tooltip should stay open (it wasn't doing that for me before), and there is a bit more space between the icon and the text (updated staging again) |
incognitojam
force-pushed
the
info-tooltips
branch
from
81d3b61
to
86cdeda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: