CanParser: add avg freq check #852
Draft
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deanlee
commented
Jun 10, 2023
deanlee
commented
- calc freq
- check freq
can/common.h
Outdated
| uint64_t check_threshold; | ||
| uint64_t first_seen_nanos = 0; | ||
| uint64_t last_seen_nanos = 0; | ||
| uint64_t check_threshold = 0; |
There was a problem hiding this comment.
maybe rename to alive_threshold?
|
Can you rebase? |
deanlee
commented
Aug 27, 2023
| @@ -275,8 +284,8 @@ void CANParser::UpdateValid(uint64_t sec) { | |||
| } | |||
|
|
|||
| const bool missing = state.last_seen_nanos == 0; | |||
| const bool timed_out = (sec - state.last_seen_nanos) > state.check_threshold; | |||
| if (state.check_threshold > 0 && (missing || timed_out)) { | |||
| const bool timed_out = (sec - state.last_seen_nanos) > state.alive_threshold; | |||
There was a problem hiding this comment.
Not quite sure how to use avg_freq to do the checking here. @adeebshihadeh: any suggestions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.