iso-tp: more checks #1487
Merged
iso-tp: more checks #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
I think this is fine, sending the initial messages out of band is definitely not the normal situation and I don't have any better ideas on how to handle it.
The asserts are good, something has gone wrong if either get hit. |
This reverts commit ba4c4f1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asserts we can't get multiple single or first frames after calling
sendon IsoTpMessage. with this, we can extend timeouts in openpilot after every response, not just consecutive frames.@gregjhogan do you think it is a good idea to make the user of the class to need to call
send(b'', setup_only=True)(or similar reset function) every time if they just want to receive?right now you can continually call
iso_tp_message.recv()and continually get first or single frames, not sure if that's the intended behavior