Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR for rewriting of remaining EKFSym functions in C++ #12

Closed
wants to merge 9 commits into from

Conversation

wolterhv
Copy link

Created according to commaai/openpilot#2386 (comment)

This is a draft PR to provide visibility into my WIP, to avoid rework.

@wolterhv wolterhv mentioned this pull request Apr 20, 2021
2 tasks
Copy link
Author

@wolterhv wolterhv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pd0wm I've finished a first pass on the implementation of the functions for this draft PR, but I'm not sure what tests you referred to in your comment (commaai/openpilot#2386 (comment)). Are you referring to the tests for locationd from the openpilot repo?

rednose/helpers/ekf_sym.h Outdated Show resolved Hide resolved
@wolterhv
Copy link
Author

wolterhv commented May 2, 2021

The chi2_lookup function could be optimised further by

  1. skipping the reading of lookup table file header and metadata, in the way assuming that lookup table file is correct and that numbers are stored as doubles and
  2. just fetching the boundary values needed for the interpolation instead of the whole row.

The current python implementation relies on the __file__ dynamic attribute to determine the location of the lookup table file. Compiled applications have naturally no knowledge of the location of their source files, so probably a fixed path will have to replace this in the C++ implementation. @pd0wm what is your opinion on this?

@pd0wm
Copy link
Contributor

pd0wm commented May 6, 2021

There really is no need to parse the npy file. Just generate the table as plaintext and include it in a header file.

@haraschax haraschax closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants