Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry [:commanded, :application, :dispatch] #423

Merged
merged 3 commits into from
Jan 31, 2021

Conversation

davydog187
Copy link
Contributor

@davydog187 davydog187 commented Dec 29, 2020

Adds telemetry to the dispatcher, which will add start and stop events
to all dispatches.

  • Documentation
  • Tests

Contributes to #387

Adds telemetry to the dispatcher, which will add start and stop events
to all dispatches.

- [  ] Documentation
- [  ] Tests
@slashdotdash
Copy link
Member

slashdotdash commented Jan 28, 2021

It would be possible to support [:commanded, :application, :dispatch, :exception] events if the aggregate returned the stacktrace on exception. This is currently being ignored by the ExecutionContext.format_reply/3 function so the stack trace is not returned to the dispatcher process.

Do you think it is worth adding the :exception telemetry event so that it supports all of the telemetry span events (:start, :stop, :exception)?

@slashdotdash slashdotdash merged commit f283a12 into commanded:master Jan 31, 2021
slashdotdash added a commit that referenced this pull request Jan 31, 2021
@davydog187
Copy link
Contributor Author

I do think it would be worth adding the exception event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants