Allow author defined option source #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweebit
added a commit
to aweebit/commander.js
that referenced
this pull request
Jul 29, 2023
OptionValueSource is only meaningful as defined in commander-js/extra-typings#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to allow the author to make up and use their own option sources for advanced cases. Since this is rare, we also want editor to suggest the values Commander knows about. At the time I wrote the code I was not comfortable doing the fancy typing to make this possible and went for just the known values to get the editor and TypeScript support.
This repo is adding extra typing, so seems a good place to try this out before adding into Commander.
Also adds
impliedwhich got left out whenOption.implies()added: tj/commander.js#1788 (comment)