-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Toolbar component #624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gciotola
previously approved these changes
Apr 19, 2024
malessani
previously approved these changes
Apr 19, 2024
gciotola
approved these changes
Apr 19, 2024
malessani
approved these changes
Apr 19, 2024
marcomontalbano
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a new
Toolbar
component that generates a horizontal navigation menu made ofButton
s andDropdown
s configured by its props.Its menu items are configurable by filling the
items
prop and they are rendered asButton
s as default behavior.Each menu item could have a grouped hierarchy of
dropdownItems
to define the sub menu shown by clicking it.If set, the
dropdownItems
prop will cause the current item to be rendered as aDropdown
with aButton
as clickable label.Thanks to the grouped behavior of the
dropdownItems
prop a divider line will be automatically rendered between each group.Example usage
Checklist