Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to "subscriptions" #63

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add support to "subscriptions" #63

merged 1 commit into from
Apr 8, 2024

Conversation

marcomontalbano
Copy link
Member

@marcomontalbano marcomontalbano commented Apr 8, 2024 •
edited
Loading

What I did

I added a new frequency attribute to the cl-add-to-cart element. It can be used to select the frequency which generates a subscription. The value must be supported by existing associated subscription_model.

<cl-add-to-cart code="POLOMXXX000000FFFFFFMXXX" frequency="three-month">
  Add to cart
</cl-add-to-cart>

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@marcomontalbano marcomontalbano marked this pull request as ready for review April 8, 2024 14:51
@marcomontalbano marcomontalbano merged commit ebaa4cb into main Apr 8, 2024
2 checks passed
@marcomontalbano marcomontalbano deleted the subscriptions branch April 8, 2024 14:52
@marcomontalbano marcomontalbano self-assigned this Apr 8, 2024
@marcomontalbano marcomontalbano added the enhancement New feature or request label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcomontalbano marcomontalbano

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcomontalbano