Add support for parcel items #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katmatt
suggested changes
Oct 17, 2017
| import javax.annotation.Nullable; | ||
| import java.time.ZonedDateTime; | ||
|
|
||
| final class ParcelImpl extends Base implements Parcel { |
There was a problem hiding this comment.
Great that you removed this class with a generated one 👍
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import io.sphere.sdk.models.Base; | ||
|
|
||
| final class ParcelMeasurementsImpl extends Base implements ParcelMeasurements { |
There was a problem hiding this comment.
Great that you removed this class with a generated one 👍
…dk into add_support_for_parcel_items
|
@katmatt added tests, don,t know why the commit doesn't show up here, but to view the added test check |
|
Looks good to me 👍 |
katmatt
approved these changes
Oct 18, 2017
| @@ -534,4 +535,27 @@ public void locale() { | |||
| return updatedOrder; | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testDeliveriesAndParcels() { | |||
There was a problem hiding this comment.
Thanks for adding this test 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1579