Migrate ProductReferenceResolver #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…va-sdk-v2-product-reference-resolver # Conflicts: # src/main/java/com/commercetools/sync/sdk2/products/utils/ProductReferenceResolutionUtils.java # src/test/java/com/commercetools/sync/sdk2/products/utils/ProductReferenceResolutionUtilsTest.java
Codecov Report
@@ Coverage Diff @@
## java-sdk-v2-product-sync-migration #937 +/- ##
========================================================================
- Coverage 96.48% 95.84% -0.65%
- Complexity 3804 3899 +95
========================================================================
Files 334 337 +3
Lines 10816 11374 +558
Branches 647 695 +48
========================================================================
+ Hits 10436 10901 +465
- Misses 280 364 +84
- Partials 100 109 +9
|
* Migrate WaitingToBeResolved class and tests * Update comment
…oduct-reference-resolver
salander85
changed the base branch from
java-sdk-v2-variant-reference-resolution-utils
to
java-sdk-v2-product-sync-migration
…oduct-reference-resolver # Conflicts: # src/test/java/com/commercetools/sync/sdk2/products/ProductSyncMockUtils.java
# Conflicts: # build.gradle # gradle-scripts/spotless.gradle
# Conflicts: # build.gradle # gradle-scripts/spotless.gradle
…2-product-sync-and-tests
…dk2/ctpprojectsource/products/ProductSyncIT.java Co-authored-by: Sarah Lander <70885646+salander85@users.noreply.github.com>
…oduct-reference-resolver
…oduct-reference-resolver # Conflicts: # build.gradle
…solver' into java-sdk-v2-product-reference-resolver
salander85
approved these changes
May 2, 2023
| getReferencesWithIds(ensureCategories(CTP_SOURCE_CLIENT, getCategoryDrafts(null, 2))); | ||
|
|
||
| ensureProductType(PRODUCT_TYPE_RESOURCE_PATH, CTP_TARGET_CLIENT); | ||
| // ensureProductType(PRODUCT_TYPE_NO_KEY_RESOURCE_PATH, CTP_TARGET_CLIENT); |
| .thenApply(ProductProjectionPagedQueryResponse::getResults) | ||
| .join(); | ||
|
|
||
| final List<ProductDraft> productDrafts = // mapToProductDrafts(products); |
There was a problem hiding this comment.
This is commented multiple times. I think you can remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate ProductReferenceResolver and related tests.