DEVX-76 migrate CategoryCustomActionBuilder and related tests #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## DEVX-75_migrate_CategoryAssetActionUtils #967 +/- ##
==============================================================================
+ Coverage 95.33% 95.61% +0.27%
- Complexity 3920 3942 +22
==============================================================================
Files 341 343 +2
Lines 11495 11516 +21
Branches 696 697 +1
==============================================================================
+ Hits 10959 11011 +52
+ Misses 428 400 -28
+ Partials 108 105 -3
|
salander85
approved these changes
May 10, 2023
| @@ -0,0 +1,246 @@ | |||
| package com.commercetools.sync.sdk2.categories; | |||
There was a problem hiding this comment.
This can be pulled from the base java-sdk-v2-category-sync-migration
| private static final ProjectApiRoot CTP_CLIENT = mock(ProjectApiRoot.class); | ||
| private static final CategorySyncOptions CATEGORY_SYNC_OPTIONS = | ||
| CategorySyncOptionsBuilder.of(CTP_CLIENT).build(); | ||
| final ProductDraft maiNewResource = mock(ProductDraft.class); |
There was a problem hiding this comment.
The variable name is weird. What does it mean?
lojzatran
merged commit c654eec
into
DEVX-75_migrate_CategoryAssetActionUtils
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JIRA: https://commercetools.atlassian.net/browse/DEVX-76