Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency cosmiconfig to v7 #1663

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 3, 2020

This PR contains the following updates:

Package Type Update Change
cosmiconfig dependencies major 6.0.0 -> 7.0.0

Release Notes

davidtheclark/cosmiconfig

v7.0.0

Compare Source

  • Breaking change: Add ${moduleName}rc.cjs and ${moduleName}.config.cjs to the default searchPlaces, to support users of "type": "module" in recent versions of Node.
  • Breaking change: Drop support for Node 8. Now requires Node 10+.

Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the 🤖 Type: Dependencies Dependency updates or something similar label Aug 3, 2020
@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2020

🦋 Changeset is good to go

Latest commit: cd30303

We got this.

This PR includes changesets to release 8 packages
Name Type
@commercetools-frontend/application-config Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch
@commercetools-frontend/mc-http-server Patch
playground Patch
@commercetools-local/visual-testing-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/370xeeya7
✅ Preview: https://merchant-center-application-kit-git-renovate-cosmiconfig-7x.commercetools.vercel.app

@vercel vercel bot temporarily deployed to Preview August 3, 2020 02:07 Inactive
@tdeekens
Copy link
Contributor

tdeekens commented Aug 3, 2020

To me the changes are fine. The .config is interesting cause it means we in theory allow custom-application-config.config.js I think which looks odd. Maybe we change post update? Not sure.

CleanShot 2020-08-03 at 09 09 05@2x

@vercel vercel bot temporarily deployed to Preview August 3, 2020 07:10 Inactive
@emmenko
Copy link
Member

emmenko commented Aug 3, 2020

We're fine, we explicitly define the searchPlaces list

searchPlaces: [
`.${moduleName}rc`,
`.${moduleName}.json`,
`${moduleName}.json`,
],

Thanks for checking

@tdeekens tdeekens merged commit 43fdb3d into master Aug 3, 2020
@tdeekens tdeekens deleted the renovate/cosmiconfig-7.x branch August 3, 2020 10:05
@ghost ghost mentioned this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 Type: Dependencies Dependency updates or something similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants