Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: to remove jest/no-jest-import rule #2797

Merged
merged 2 commits into from Sep 7, 2022

Conversation

tdeekens
Copy link
Contributor

@tdeekens tdeekens commented Sep 7, 2022

Summary

In eslint-plugin-jest v27 the rule jest/no-jest-import has been removed. So it can’t be used in the eslint-config-mc-app. Given that it’s not recommended to be used anymore already here we could remove it already.

This will mean that consumers can update to v27 of eslint-plugin-jest already.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: 45be8ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/custom-applications Patch
@commercetools-website/components-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-nmxfndmc7-commercetools.vercel.app
https://appkit-sha-f826fe5530ca46bbe7005fe2439be6b64d51d6a0.commercetools.vercel.app
https://appkit-pr-2797.commercetools.vercel.app

Built with commit 45be8ae.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@tdeekens tdeekens merged commit 03e9772 into main Sep 7, 2022
@tdeekens tdeekens deleted the td/remove-no-jest-imports branch September 7, 2022 08:58
@ghost ghost mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Status: Dev Review Waiting for technical reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants