Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine some regex #3503

Merged
merged 8 commits into from
May 2, 2024
Merged

refactor: refine some regex #3503

merged 8 commits into from
May 2, 2024

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Apr 30, 2024

Follow up of #3495

@emmenko emmenko requested a review from a team as a code owner April 30, 2024 12:57
Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: d3d190b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/constants Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/l10n Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/url-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 10:20am

Copy link
Contributor

@Rhotimee Rhotimee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

packages/constants/src/constants.ts Dismissed Show dismissed Hide dismissed
@tdeekens tdeekens merged commit b5e797f into main May 2, 2024
18 checks passed
@tdeekens tdeekens deleted the nm-fix-project-regex branch May 2, 2024 10:25
@ct-changesets ct-changesets bot mentioned this pull request May 2, 2024
ddouglasz pushed a commit that referenced this pull request May 22, 2024
* fix: refine project key regex

* fix: refine entry point regex

* docs: update changeset

* refactor: docs

* fix: refine regex

* fix: refine regex to avoid potential exponential backtracking

* refactor: align regexes

* docs: adjust explanation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants