Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prettier to v2 #1506

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 23, 2020

This PR contains the following updates:

Package Type Update Change
prettier (source) devDependencies major 1.19.1 -> 2.0.2

Release Notes

prettier/prettier

v2.0.2

Compare Source

diff

2.0 regressions
JavaScript: Fix formatting of pseudo-elements and pseudo-classes in styled-components template literals (#​7842 by @​thorn0)
// Input
const Foo = styled.div`
  ${media.smallDown}::before {}
`;

// Prettier 2.0.0
const Foo = styled.div`
  ${media.smallDown}: : before{
  }
`;

// Prettier 2.0.2
const Foo = styled.div`
  ${media.smallDown}::before {
  }
`;
TypeScript: Avoid trailing commas on index signatures with only one parameter (#​7836 by @​bakkot)

TypeScript index signatures technically allow multiple parameters and trailing commas, but it's an error to have multiple parameters there, and Babel's TypeScript parser does not accept them. So Prettier now avoids putting a trailing comma there when you have only one parameter.

// Input
export type A = {
  a?: {
    [
      x: string
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};

// Prettier 2.0.0
export type A = {
  a?: {
    [
      x: string,
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};

// Prettier 2.0.2
export type A = {
  a?: {
    [
      x: string
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};
Revert "markdown: fix redundant leading spaces in markdown list" (#​7847)

See #​7846

Other changes
TypeScript: Fix prettier-ignore in union types (#​7798 by @​thorn0)
// Input
export type a =
  // foo
  | foo1&foo2
  // prettier-ignore
  | bar1&bar2
  // baz
  | baz1&baz2;

// Prettier 2.0.0
export type a =
  // foo
  | foo1&foo2
    // prettier-ignore
  // prettier-ignore
  | (bar1 & bar2)
  // baz
  | (baz1 & baz2);

// Prettier 2.0.2
export type a =
  // foo
  | (foo1 & foo2)
  // prettier-ignore
  | bar1&bar2
  // baz
  | (baz1 & baz2);

v2.0.1

Compare Source

diff

API: Fix build script to not corrupt import-fresh module (#​7820 by @​thorn0)

v2.0.0

Compare Source

diff

🔗 Release Notes


Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Mar 23, 2020

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻️ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you check the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
npm WARN deprecated mkdirp@0.5.4: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
lerna notice cli v3.20.2
lerna info versioning independent
lerna info bootstrap root only
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "network:": network:31879

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2020-03-26T11_28_31_157Z-debug.log
lerna ERR! npm install --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879 exited 1 in 'nodejs'
lerna ERR! npm install --ignore-scripts --ignore-engines --ignore-platform --mutex network:31879 exited 1 in 'nodejs'

@renovate
Copy link
Contributor Author

renovate bot commented Mar 26, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #1506 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   98.62%   98.62%   +<.01%     
==========================================
  Files         128      128              
  Lines        3272     3273       +1     
  Branches      754      754              
==========================================
+ Hits         3227     3228       +1     
  Misses         41       41              
  Partials        4        4
Impacted Files Coverage Δ
...ages/csv-parser-price/test/helpers/price-sample.js 100% <ø> (ø) ⬆️
packages/sdk-middleware-auth/src/utils.js 100% <ø> (ø) ⬆️
packages/sync-actions/src/order-actions.js 100% <100%> (ø) ⬆️
packages/state-importer/src/main.js 100% <100%> (ø) ⬆️
packages/sync-actions/src/assets-actions.js 85.71% <100%> (ø) ⬆️
...sync-actions/src/utils/combine-validity-actions.js 100% <100%> (ø) ⬆️
packages/api-request-builder/src/classify.js 100% <100%> (ø) ⬆️
packages/sdk-auth/src/tokenProvider.js 100% <100%> (ø) ⬆️
packages/product-json-to-csv/src/writer.js 100% <100%> (ø) ⬆️
packages/product-json-to-xlsx/src/writer.js 100% <100%> (ø) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4ce26...d31b0bc. Read the comment docs.

@daern91 daern91 merged commit 51f1051 into master Mar 26, 2020
@daern91 daern91 deleted the renovate/major-all branch March 26, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants