Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync-actions): add set key actions #1514

Conversation

NickDevG
Copy link

@NickDevG NickDevG commented Apr 3, 2020

Summary

Adding setkey to Product Discount, Customer and Zone

Description

Adding the detection of the setKey action for the following resources:

  • Product Discount
  • Customer
  • Zone

Adding the corresponding tests for each resource type.

@NickDevG NickDevG requested review from katmatt and daern91 April 3, 2020 08:48
@NickDevG NickDevG self-assigned this Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #1514 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1514   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files         128      128           
  Lines        3273     3273           
  Branches      754      754           
=======================================
  Hits         3228     3228           
  Misses         41       41           
  Partials        4        4           
Impacted Files Coverage Δ
packages/sync-actions/src/customer-actions.js 100.00% <ø> (ø)
...ages/sync-actions/src/product-discounts-actions.js 100.00% <ø> (ø)
packages/sync-actions/src/zones-actions.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55add1e...0ee349a. Read the comment docs.

Copy link
Contributor

@katmatt katmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎 Thanks a lot 😄 Looks very good to me 👍

Copy link
Contributor

@daern91 daern91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

@NickDevG
Copy link
Author

NickDevG commented Apr 3, 2020

Perfect, feel free to merge 😉

@daern91 daern91 changed the title Add setkey action to Product Discount, Customer and Zone sync actions feat(sync-actions): add set key actions Apr 3, 2020
@daern91 daern91 merged commit 2cfd58e into master Apr 3, 2020
@daern91 daern91 deleted the nl-add-set-key-to-product-discount-customer-and-zone-sync-actions branch April 3, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants