refactor(api-request-builder): rename createService argument #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 128 128
Lines 3281 3281
Branches 757 757
=======================================
Hits 3236 3236
Misses 41 41
Partials 4 4
Continue to review full report at Codecov.
|
jherey
force-pushed
the
1523-rename-create-service-argument
branch
from
76eb9ef
to
e5c03e0
Compare
daern91
changed the title
katmatt
approved these changes
Apr 6, 2020
affects: @commercetools/api-request-builder the second argument for createService is changed to projectKey ISSUES CLOSED: #1523
jherey
force-pushed
the
1523-rename-create-service-argument
branch
from
e5c03e0
to
f96eed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renamed
optionstoprojectKeyDescription
Changed the 2nd argument to
createServicefunction toprojectKey. This makes it easy to read the code and understand, as againstoptionswhich means an object.affects: @commercetools/api-request-builder