fix(sdk-middleware-http): try json parse with catch block #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into try-catch-json-parse
markus-azer
commented
Feb 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 128 128
Lines 3347 3354 +7
Branches 774 775 +1
=======================================
+ Hits 3300 3307 +7
Misses 43 43
Partials 4 4
Continue to review full report at Codecov.
|
…s into try-catch-json-parse
markus-azer
commented
Mar 2, 2021
| @@ -63,7 +63,7 @@ export const customLineItem = [ | |||
| slug: 'mySlug', | |||
| taxCategory: { | |||
| typeId: 'tax-category', | |||
| id: 'fd890829-7554-4c22-a806-d6c6dcdbb0c5', | |||
| id: 'd205cc42-e399-424a-b6fc-0ef44772d6bc', | |||
There was a problem hiding this comment.
changed it cause i accidentally deleted it
Comment on lines
+108
to
+120
| expect(data).toHaveLength(11) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'CartCreated'})) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'PaymentCreated'})) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'CustomerCreated'})) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'ReviewCreated'})) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'OrderCreated'})) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'CartCreated'})) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'Order'})) | ||
| expect(data).toContainEqual(expect.objectContaining({type: 'Cart'})) | ||
| expect(data).toContainEqual(expect.objectContaining({email: 'foo@bar.de'})) | ||
| expect(data).toContainEqual(expect.objectContaining({amountPlanned: { type: 'centPrecision', currencyCode: 'EUR', centAmount: 100, fractionDigits: 2}})) | ||
| expect(data).toContainEqual(expect.objectContaining({name: {de: 'deutscherListenName', en: 'englishListName'}})) | ||
| expect(data).toContainEqual(expect.objectContaining({text: 'Review text'})) |
There was a problem hiding this comment.
these checks to further be easy if new object were introduced
daern91
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wrap json.parse with try and catch
Description
Wrapping it so in case we receive any invalid json, instead of directly parsing it which could lead to
Unexpected end of JSON input, in this case, if there is any error then it get catch and then forwardbodyto consumer.