Fix issue with intermittent promise rejection error #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2907a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
+ Coverage 94.68% 94.71% +0.03%
==========================================
Files 145 145
Lines 4988 4998 +10
Branches 1363 1365 +2
==========================================
+ Hits 4723 4734 +11
+ Misses 262 261 -1
Partials 3 3
|
markus-azer
approved these changes
Jun 28, 2023
…rror - add an error catch block to handle serialization errors
- DEVX-180 write tests for new bug fix
- use correct error class for error handling. - change network error to server error
ajimae
force-pushed
the
fix/issue-with-intermittent-promise-rejection-error
branch
from
bb04290
to
f2907a1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Serialization of response object throws unhandled promise rejection errors
Description
Intermittent unhandled promise rejection errors occurs due to bad object serialization.
Todo
Related Issues
#1858
DEVX-180 - Jira