Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing sync action for StandalonePrice entity #1863

Merged
merged 6 commits into from
Jul 4, 2023

Conversation

ragafus
Copy link
Contributor

@ragafus ragafus commented Jun 26, 2023

Summary

This PR adds support for StandalonePrice setKey, setValidFrom, setValidUntil, setValidFromAndUntil and changeActive actions.

Description

Todo

Staged changeValue update action needed for https://commercetools.atlassian.net/browse/PRC-2676 will be introduced with a follow-up ticket

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation
  • Type label for the PR

@ragafus ragafus self-assigned this Jun 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

🦋 Changeset detected

Latest commit: ff576b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools/sync-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ragafus ragafus force-pushed the rg-standalone-prices-new-actions branch from 8d63885 to 6372236 Compare June 26, 2023 13:26
@ragafus ragafus requested review from dogayuksel, ARRIOLALEO and a team June 26, 2023 13:31
@ragafus ragafus marked this pull request as ready for review June 26, 2023 13:31
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1863 (ff576b9) into master (38ee4e1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
- Coverage   94.71%   94.71%   -0.01%     
==========================================
  Files         145      145              
  Lines        4998     4997       -1     
  Branches     1365     1365              
==========================================
- Hits         4734     4733       -1     
  Misses        261      261              
  Partials        3        3              
Impacted Files Coverage Δ
packages/sync-actions/src/prices-actions.js 100.00% <ø> (ø)
packages/sync-actions/src/prices.js 100.00% <100.00%> (ø)

@ragafus ragafus force-pushed the rg-standalone-prices-new-actions branch 2 times, most recently from 30e102d to da1f0cf Compare June 27, 2023 17:09
Copy link
Member

@markus-azer markus-azer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really pretty good 👍 💯 , just ci complaining about more testing, and its kinda hard to follow the added tests cause of the added indentation.

@ragafus ragafus force-pushed the rg-standalone-prices-new-actions branch 3 times, most recently from e85ebc4 to 812c8f3 Compare July 4, 2023 11:40
@ragafus ragafus requested a review from ARRIOLALEO July 4, 2023 11:44
@ragafus ragafus force-pushed the rg-standalone-prices-new-actions branch from 812c8f3 to 2b001e6 Compare July 4, 2023 11:54
@ragafus ragafus force-pushed the rg-standalone-prices-new-actions branch from 03aacbd to ff576b9 Compare July 4, 2023 13:35
@markus-azer markus-azer merged commit 7ed7a66 into master Jul 4, 2023
5 of 6 checks passed
@markus-azer markus-azer deleted the rg-standalone-prices-new-actions branch July 4, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants