-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing sync action for StandalonePrice entity #1863
Conversation
🦋 Changeset detectedLatest commit: ff576b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8d63885
to
6372236
Compare
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
- Coverage 94.71% 94.71% -0.01%
==========================================
Files 145 145
Lines 4998 4997 -1
Branches 1365 1365
==========================================
- Hits 4734 4733 -1
Misses 261 261
Partials 3 3
|
30e102d
to
da1f0cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really pretty good 👍 💯 , just ci complaining about more testing, and its kinda hard to follow the added tests cause of the added indentation.
e85ebc4
to
812c8f3
Compare
812c8f3
to
2b001e6
Compare
03aacbd
to
ff576b9
Compare
Summary
This PR adds support for StandalonePrice
setKey
,setValidFrom
,setValidUntil
,setValidFromAndUntil
andchangeActive
actions.Description
Todo
Staged
changeValue
update action needed for https://commercetools.atlassian.net/browse/PRC-2676 will be introduced with a follow-up ticketType
label for the PR