Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-request-builder): add the types service #24

Merged
merged 1 commit into from Jan 19, 2017

Conversation

Siilwyn
Copy link
Contributor

@Siilwyn Siilwyn commented Jan 18, 2017

affects: @commercetools/api-request-builder

Summary

Description

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation

affects: @commercetools/api-request-builder
@codecov-io
Copy link

Current coverage is 96.49% (diff: 100%)

Merging #24 into master will not change coverage

@@             master        #24   diff @@
==========================================
  Files            42         42          
  Lines           742        742          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            716        716          
  Misses           26         26          
  Partials          0          0          

Powered by Codecov. Last update 99eb6e9...f853ec6

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We should also add all "missing" services

@Siilwyn Siilwyn merged commit 7a0cba3 into master Jan 19, 2017
@Siilwyn Siilwyn deleted the feat-api-request-builder-types branch January 19, 2017 09:22
@junajan junajan mentioned this pull request Mar 17, 2017
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants