Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup changesets, move to gh actions #1338

Merged
merged 3 commits into from
May 12, 2020
Merged

chore: setup changesets, move to gh actions #1338

merged 3 commits into from
May 12, 2020

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented May 11, 2020

https://github.com/atlassian/changesets

TL;DR: changesets are a replacement of lerna changelog, as they provide a more convenient way of writing changelogs incrementally. In fact, the tool is primarily built to work in monorepositories.

Additionally, using the bot and the github action, the workflow of releasing becomes almost fully automated.

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2020

💥 No Changeset

Latest commit: 3a89153

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/ui-kit/g0xisznc6
✅ Preview: https://ui-kit-git-nm-changesets.commercetools.now.sh

Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks familiar. Are the s3r3ts set up already 🤖

.github/workflows/release.yml Show resolved Hide resolved
@emmenko
Copy link
Member Author

emmenko commented May 11, 2020

Are the s3r3ts set up already

Yep

image

Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Nice. I am still feeling itchy about having lerna and changesets and yarn workspaces but when changesets maybe improves their canary release story a bit that ahould go away.

Is there a contributing doc here we should update?

@emmenko
Copy link
Member Author

emmenko commented May 11, 2020

I am still feeling itchy about having lerna and changesets and yarn workspaces but when changesets maybe improves their canary release story a bit that ahould go away.

Yeah that part should improve. They seem to be pretty active in maintaining the project, so I hope that if we give the proper input (e.g. RFC) we can find a more permanent solution.

@emmenko
Copy link
Member Author

emmenko commented May 11, 2020

PS: there is a WIP PR that implements a pre snapshot command, which might do what we need for the canary releases.

@emmenko emmenko requested a review from jonnybel May 11, 2020 19:00
@emmenko emmenko added the 🛠 Type: Tooling Things related to development tools for the repository label May 11, 2020
@emmenko
Copy link
Member Author

emmenko commented May 11, 2020

FYI: I "removed" the integration with CircleCI, we only run on GitHub Actions now.

Copy link
Contributor

@jonnybel jonnybel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ✨ Thanks a lot for this!

@emmenko emmenko merged commit c5b6336 into master May 12, 2020
@emmenko emmenko deleted the nm-changesets branch May 12, 2020 08:17
@emmenko emmenko mentioned this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Type: Tooling Things related to development tools for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants