-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup changesets, move to gh actions #1338
Conversation
💥 No ChangesetLatest commit: 3a89153 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/ui-kit/g0xisznc6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks familiar. Are the s3r3ts set up already 🤖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Nice. I am still feeling itchy about having lerna and changesets and yarn workspaces but when changesets maybe improves their canary release story a bit that ahould go away.
Is there a contributing doc here we should update?
Yeah that part should improve. They seem to be pretty active in maintaining the project, so I hope that if we give the proper input (e.g. RFC) we can find a more permanent solution. |
PS: there is a WIP PR that implements a |
FYI: I "removed" the integration with CircleCI, we only run on GitHub Actions now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect ✨ Thanks a lot for this!
https://github.com/atlassian/changesets
TL;DR: changesets are a replacement of lerna changelog, as they provide a more convenient way of writing changelogs incrementally. In fact, the tool is primarily built to work in monorepositories.
Additionally, using the bot and the github action, the workflow of releasing becomes almost fully automated.