Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent "Unsupported tarball" exception upon download of Git dependency containing problematic symlinks #64

Closed

Conversation

dynamicboid
Copy link
Contributor

@dynamicboid dynamicboid commented Oct 27, 2022

When Stack projects contain extra-dep Git dependencies that have certain problematic symlinks, stack will throw an error when building a project if it is unable to resolve those symlinks successfully. However, on subsequent invocations of Stack, it seems that Pantry is able to cache the Git artifacts and enable Stack to run successfully. This PR seeks to address the former issue of Stack failing upon the first invocation on such a project. This may thus partially address issues #4913, #5004 and #5603 on the Stack repository as well as #23 on the Haskell shower repo.

@mpilgrem
Copy link
Member

Merged manually with d813274.

Rather than normalise getFiles, it seemed to me better to add normalisation to the ATZip limb of foldArchive, as foldTar already normalises the other two limbs.

@mpilgrem mpilgrem closed this Aug 17, 2023
@neilmayhew
Copy link

cc @philderbeast

@neuroevolutus
Copy link

@mpilgrem, thanks so much for taking the time to review this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants