logUseColor now defaults to False on Windows, even when verbose #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the required macOS builds failing with: Does that count against this PR? I don't know what to do about it. |
snoyberg
requested changes
Sep 27, 2018
rio/src/RIO/Prelude/Logger.hs
Outdated
| @@ -315,7 +316,7 @@ logOptionsHandle handle' verbose = liftIO $ do | |||
| , logVerboseFormat = return verbose | |||
| , logTerminal = terminal | |||
| , logUseTime = verbose | |||
| , logUseColor = verbose && terminal | |||
| , logUseColor = verbose && terminal && os /= "mingw32" | |||
There was a problem hiding this comment.
I'd rather use the WINDOWS CPP flag, so that we use the same logic throughout the codebase for checking for Windows. Otherwise, looks great!
snoyberg
approved these changes
Sep 27, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
Simple change in
logOptionsHandle. Updated the haddock comment. Updated the change log.