Skip to content

Commit

Permalink
Merge pull request #5279 from nh2/scroll-up-tip
Browse files Browse the repository at this point in the history
Add tip to scroll up on package build failure.
  • Loading branch information
snoyberg committed May 4, 2020
2 parents 0ad0d02 + b468488 commit 6a04613
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions ChangeLog.md
Expand Up @@ -13,6 +13,9 @@ Behavior changes:

Other enhancements:

* Build failures now show a hint to scroll up to the corresponding section
[#5279](https://github.com/commercialhaskell/stack/issues/5279)

Bug fixes:


Expand Down
2 changes: 1 addition & 1 deletion src/Stack/Types/Build.hs
Expand Up @@ -348,7 +348,7 @@ showBuildError isBuildingSetup exitCode mtaskProvides execName fullArgs logFiles
(True, Nothing) -> "simple Setup.hs"
(True, Just taskProvides') -> "custom Setup.hs for package " ++ dropQuotes (packageIdentifierString taskProvides')
) ++
" using:\n " ++ fullCmd ++ "\n" ++
" (scroll up to its section to see the error) using:\n " ++ fullCmd ++ "\n" ++
" Process exited with code: " ++ show exitCode ++
(if exitCode == ExitFailure (-9)
then " (THIS MAY INDICATE OUT OF MEMORY)"
Expand Down

0 comments on commit 6a04613

Please sign in to comment.