Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run benchmarks specified as build targets #1412

Closed
mgsloan opened this issue Nov 24, 2015 · 2 comments
Closed

Only run benchmarks specified as build targets #1412

mgsloan opened this issue Nov 24, 2015 · 2 comments

Comments

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Nov 24, 2015

Currently which benchmark targets are selected is ignored when actually running them - see this FIXME. Should be as simple as providing the benchmarks as component parameters here, and testing that it works properly.

@rvion
Copy link
Contributor

@rvion rvion commented Nov 24, 2015

@mgsloan
Copy link
Contributor Author

@mgsloan mgsloan commented Nov 25, 2015

Ah, yes, fixed. That's what I get for using unpushed SHAs! (I've got an emacs keybinding that creates a github url based on the current SHA + line)

@mgsloan mgsloan closed this in a1ff11f Nov 25, 2015
mgsloan added a commit that referenced this issue Nov 25, 2015
Only run benchmarks specified as build targets (closes #1412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants