Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package dirtiness checker ignores missing files #1841

Closed
mgsloan opened this issue Feb 26, 2016 · 1 comment
Closed

Package dirtiness checker ignores missing files #1841

mgsloan opened this issue Feb 26, 2016 · 1 comment

Comments

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Feb 26, 2016

Reported by charles-cooper in #1838 (comment)

Another interesting thing I noticed is that running rm src/Data/Foo.hs in that project results in a stack running a rebuild .. and exiting successfully.

I had an inkling this was an issue with the dirty checker. Turns out that removing a file does not cause a package to be considered dirty. This likely eluded detection because usually when removing a module, you cause the cabal file to be dirty.

@mgsloan
Copy link
Contributor Author

@mgsloan mgsloan commented May 15, 2016

Fixed!

@mgsloan mgsloan closed this May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant