New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding when disabling profiling #2023

Closed
chrisdone opened this Issue Apr 11, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@chrisdone
Member

chrisdone commented Apr 11, 2016

Currently running stack build --profile and then stack build triggers unregistering and rebuilding of all dependencies. It's not supposed to do that.

@chrisdone chrisdone self-assigned this Apr 11, 2016

@chrisdone chrisdone added the type: bug label Apr 11, 2016

@chrisdone chrisdone closed this in 2f59325 Apr 11, 2016

chrisdone added a commit that referenced this issue Apr 11, 2016

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Apr 11, 2016

Oh man, I didn't realize that list existed. I've moved it next to the options generation code - 75294eb

Is isStackopt still an apt name? As far as I understand it, these are all the options that shouldn't cause package rebuild dirtiness. This can either be because we know through a different mechanism that we need to rebuild the package when it's due to say, a dependency change. Similarly, when resolving dependencies for a profiling build, it only considers packages that are built with profiling.

So based on this, I'm thinking options like extra-lib-dirs and extra-include-dirs shouldn't be in the list? These options come from the stack.yaml and changing them should cause a rebuild.

@chrisdone

This comment has been minimized.

Member

chrisdone commented Apr 12, 2016

Right, there's a different mechanism to trigger building all the profiling packages when we enable profiling, so this doesn't need to be in this list. But beyond that I'm not sure about the other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment