Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpack doesn't pick up changes to project folders and files #2051

Closed
lukexi opened this issue Apr 21, 2016 · 3 comments
Closed

hpack doesn't pick up changes to project folders and files #2051

lukexi opened this issue Apr 21, 2016 · 3 comments

Comments

@lukexi
Copy link
Contributor

@lukexi lukexi commented Apr 21, 2016

As a knock-on effect of #1815, hpack's excellent feature of automatically generating the exported modules list from the source directory doesn't get triggered when I add new modules. This is presumably also relevant to its globbing capabilities.

So, the modification time of the package.yaml file is not the only criterion for when hpack should be run...

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Apr 22, 2016

This is also relevant to file-watch. Since hpath can watch globs, we also need to watch directories for additions that match the globs. We will also need such glob watching because cabal recently added the feature (not yet released)

@mgsloan mgsloan added this to the P2: Should milestone Apr 22, 2016
@mitchellwrosen
Copy link
Contributor

@mitchellwrosen mitchellwrosen commented May 8, 2016

Ahh, I was wondering why my workflow felt so awkward lately! I've found myself constantly touching my cabal file as I rename modules, etc, whereas before, hpack would take care of updating the cabal file automatically.

mgsloan added a commit that referenced this issue May 14, 2016
@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented May 14, 2016

#1813 was resolved more properly by #2011, so I've reverted the old resolution of it, so this is now also fixed!

@mgsloan mgsloan closed this May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants