Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run autoreconf in git repos? Alternatively, add configure script to upstream packages #3534

Closed
mgsloan opened this issue Oct 30, 2017 · 1 comment

Comments

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Oct 30, 2017

It looks like some fairly core packages like process and time do not include the configure script, instead requiring the user to run autoreconf -i. The source dist, on the other hand, includes the configure script. This causes issues when those packages are referenced by git repo - see this and this.

Two options here:

  1. Run autoreconf -i automatically? Seems ok. Does cabal-install do this? Do we care what it does? Perhaps we should just detect the absence of a configure script, and try this incase it works.

  2. Fix the packages to include the configure script.

Thoughts?

For those who are visiting this issue, the workaround is straightforward. Just check out the dependency as a git repo, add it to your packages list, and run autoreconf -i

@mgsloan mgsloan added this to the P2: Should milestone Oct 30, 2017
snoyberg added a commit that referenced this issue Nov 22, 2017
@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Nov 22, 2017

See #3598

snoyberg added a commit that referenced this issue Nov 22, 2017
mgsloan added a commit that referenced this issue Nov 23, 2017
Automatically run autoreconf -i when needed #3534
@mgsloan mgsloan closed this Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.