Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and report when a new Stack version is available #3746

Closed
snoyberg opened this issue Jan 4, 2018 · 5 comments
Closed

Detect and report when a new Stack version is available #3746

snoyberg opened this issue Jan 4, 2018 · 5 comments
Milestone

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Jan 4, 2018

The cassavapocalypse (and ongoing bug reports till today) indicate that users need to be nudged to upgrade. Stack should have some kind of logic in it to detect that a new version is available and offer to upgrade.

The exact details, like how often to check for updates, are totally up for grabs here. Opening this to start the discussion around implementation.

@snoyberg snoyberg added this to the P1: Must milestone Jan 4, 2018
@borsboom
Copy link
Contributor

borsboom commented Jan 4, 2018

I thought there was already an issue open about this with some discussion, but I can't find it right now. Would it be often enough to only check when it's going to a server for some other reason already (like getting a new snapshot or updating the package index)? If more frequency is needed, it certainly shouldn't check more than once a day.

@mgsloan
Copy link
Contributor

mgsloan commented Jan 4, 2018

Yes, this is a duplicate of #1681 . I think the main reason it hasn't been done is just figuring out how to do it efficiently.

One approach might be to just sometimes do it in parallel with build, and cancel the request if the build finishes before the version check. Could just generate a random number and check 1 in every 20 builds or something. Maybe that is too arbitrary :)

@MaxGabriel
Copy link
Contributor

This might require too much of a server component, but you might also want support for displaying a custom message along with it. That way you could say "You're using stack 1.5, the latest version is 1.6. It includes a fix for Cabal flag parsing". or "It fixes a critical security vulnerability"

@dpwiz
Copy link

dpwiz commented Jan 9, 2018

Please don't make it mandatory or fail-prone, like repo does (did?). Very annoying to get network-related failures while using it on entirely local project.

@snoyberg
Copy link
Contributor Author

Closing as duplicate of #1681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants